Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial audio #273

Merged
merged 4 commits into from
Jan 4, 2023
Merged

Initial audio #273

merged 4 commits into from
Jan 4, 2023

Conversation

Eraden
Copy link
Contributor

@Eraden Eraden commented Dec 29, 2022

Rationale

#131

Changes

Add initial audio which include:

  • Initial messages to manage audio
  • Main theme music

@Eraden
Copy link
Contributor Author

Eraden commented Dec 29, 2022

Music source: https://tabletopaudio.com
Track: Red Planet ambience + music

@Segelente Segelente changed the base branch from main to dev December 30, 2022 08:11
@Nereuxofficial
Copy link
Contributor

Feel free to request my review or ask us any questions if you need help during the implementation. Once this PR is merged we'll make a new release with english as a default language 🥳

Copy link
Contributor

@Nereuxofficial Nereuxofficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also a lot of good cleanups. Unfortunately there seem to be some merge conflicts for now

@Eraden
Copy link
Contributor Author

Eraden commented Jan 3, 2023

Tomorrow I will resolve them

@Nereuxofficial Nereuxofficial merged commit 3409424 into red-life-project:dev Jan 4, 2023
@Nereuxofficial
Copy link
Contributor

Thanks again for implementing this. I will create a new release soon featuring these PRs and hopefully a MacOS build :)

@Eraden Eraden deleted the audio branch January 4, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants