Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2239140: Store application namespace as an annotation #148

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

ShyamsundarR
Copy link

This helps when an ApplicationSet is deleted prior to actual drpc deletion, as the application namespace, and VRG naming using the same, can continue to find the required resources to delete and cleanup.

Signed-off-by: Shyamsundar Ranganathan [email protected]
(cherry picked from commit 24f81bb)

This helps when an ApplicationSet is deleted prior to actual
drpc deletion, as the application namespace, and VRG naming
using the same, can continue to find the required resources to
delete and cleanup.

Signed-off-by: Shyamsundar Ranganathan <[email protected]>
(cherry picked from commit 24f81bb)
@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ShyamsundarR

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2023

@ShyamsundarR: This pull request references Bugzilla bug 2239140, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.14.0) matches configured target release for branch (ODF 4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

Bug 2239140: Store application namespace as an annotation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2023

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@ShyamsundarR: This pull request references Bugzilla bug 2239140, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.14.0) matches configured target release for branch (ODF 4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

Bug 2239140: Store application namespace as an annotation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ShyamsundarR ShyamsundarR merged commit 22b3354 into red-hat-storage:release-4.14 Oct 12, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2023

@ShyamsundarR: All pull requests linked via external trackers have merged:

Bugzilla bug 2239140 has been moved to the MODIFIED state.

In response to this:

Bug 2239140: Store application namespace as an annotation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ShyamsundarR ShyamsundarR deleted the bz2239140 branch February 8, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant