Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test automation for reclaimspace disable operation #10862

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

paraggit
Copy link
Contributor

Adding test automation for reclaimspace disable operation

    Steps:
        1.	Create a PVC from the CephBlockPool and attach it to a pod.
        2.	To disable the reclaimspace operation for the PVC, set suspend = true and change the state annotation
            to unmanaged.
        3.	Verify that the reclaimspace operation is disabled for the PVC by checking that suspend = true is set.
        4.	Re-enable the reclaimspace cronjob by removing suspend = true and changing the state annotation back
            to managed for each PVC.
        5.	Verify that all reclaimspace cronjobs are enabled.

@paraggit paraggit requested a review from a team as a code owner November 14, 2024 18:00
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Nov 14, 2024
Copy link

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: paraggit

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@paraggit paraggit requested review from a team as code owners November 15, 2024 03:52
@pull-request-size pull-request-size bot added size/XXL and removed size/L PR that changes 100-499 lines labels Nov 15, 2024
@paraggit paraggit force-pushed the disable_reclaimspace_operation branch 2 times, most recently from 5b5adff to 50e7f13 Compare November 15, 2024 04:05
@pull-request-size pull-request-size bot added size/L PR that changes 100-499 lines and removed size/XXL labels Nov 15, 2024
@paraggit paraggit removed request for a team November 15, 2024 04:06
self.pod_objs.append(pod_obj)

# Disable Reclaimspace operation for the PVC
log.info("Changing reclaimspace cronjob status to disable for all PVC object.")
Copy link
Contributor

@shyRozen shyRozen Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm missing something but if we want to disable the reclaim space, don't we need to enable it first?
If it is enabled by default then it is valid.
If not you are disabling but then enabling. I think it should go the other way around.
Enable->disable and then you can enable it back if we want to see that it can be reversed again to enable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reclaimspace is enabled by default on the cluster, so the flow starts with disabling and then enabling it to test reversibility.

Signed-off-by: Parag Kamble <[email protected]>
@paraggit paraggit changed the title [WIP] Adding test automation for reclaimspace disable operation Adding test automation for reclaimspace disable operation Nov 19, 2024
@paraggit paraggit requested review from a team and removed request for a team November 19, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L PR that changes 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants