Upgrade to PHPParser 5 and PHPStan 2

[samsonasik]

Require patch branch of vendor-patches

• Php parser 5 latest upgrade vendor-patches#9

Ref rectorphp/rector#8815

[samsonasik]

phpstan/phpdoc-parser seems needs to be upgraded to v2.0 as well to handle error undefined constant:

[ERROR] Could not process "rules/Php81/NodeFactory/EnumFactory.php" file, due  
         to:                                                                    
         "Undefined constant                                                    
         PHPStan\PhpDocParser\Ast\ConstExpr\ConstExprStringNode::SINGLE_QUOTED".
         On line: 434        

ref https://github.com/phpstan/phpdoc-parser/blob/c00d78fb6b29658347f9d37ebe104bffadf36299/src/Ast/ConstExpr/ConstExprStringNode.php#L19

upgrading it currently got error:

There was 1 error:

1) Rector\Tests\Issues\DoubleRun\DoubleRunTest::test with data set #0 ('/Users/samsonasik/www/rector-...hp.inc')
Illuminate\Contracts\Container\BindingResolutionException: Unresolvable dependency resolving [Parameter #0 [ <required> array $usedAttributes ]] in class PHPStan\PhpDocParser\ParserConfig

will continue trying.

[samsonasik]

Register ParserConfig as service seems handle it d301344

[staabm]

phpstan/phpdoc-parser seems needs to be upgraded to v2.0

Correct 👍

[samsonasik]

PHPStan RichParser seems cause error on read curly array: $string{0}

There was 1 error:

1) Rector\Tests\Php74\Rector\ArrayDimFetch\CurlyToSquareBracketArrayStringRector\CurlyToSquareBracketArrayStringRectorTest::test with data set #0 ('/Users/samsonasik/www/rector-...hp.inc')
PHPStan\Parser\ParserErrorsException: Syntax error, unexpected '{', expecting ';', Syntax error, unexpected '{', expecting ';', Syntax error, unexpected '{', expecting ';'

phar:///Users/samsonasik/www/rector-src/vendor/phpstan/phpstan/phpstan.phar/src/Parser/RichParser.php:70

I will try if it possible to use native PHPParser Parser.

[samsonasik]

use simple parser for defaultAnalysisParser, with native parser php 7.0 469b596

Before

There was 1 error:

1) Rector\Tests\Php74\Rector\ArrayDimFetch\CurlyToSquareBracketArrayStringRector\CurlyToSquareBracketArrayStringRectorTest::test with data set #0 ('/Users/samsonasik/www/rector-...hp.inc')
PHPStan\Parser\ParserErrorsException: Syntax error, unexpected '{', expecting ';', Syntax error, unexpected '{', expecting ';', Syntax error, unexpected '{', expecting ';'

phar:///Users/samsonasik/www/rector-src/vendor/phpstan/phpstan/phpstan.phar/src/Parser/RichParser.php:70

After

➜  rector-src git:(upgrade-to-php-parser5-and-phpstan-2) ✗ vendor/bin/phpunit rules-tests/Php74/Rector/ArrayDimFetch/CurlyToSquareBracketArrayStringRector/CurlyToSquareBracketArrayStringRectorTest.php --filter=#0
PHPUnit 10.5.38 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.12
Configuration: /Users/samsonasik/www/rector-src/phpunit.xml

.                                                                   1 / 1 (100%)

Time: 00:00.316, Memory: 62.50 MB

OK (1 test, 2 assertions)

This needs to fallback to php 8.0 feature as well, I will continue :)

[samsonasik]

I got it, using ->createForNewestSupportedVersion() is fine to be on default, then if it catch PHPStan\Parser\ParserErrorsException, fallback to use php 7 parser when doing parsing, see 3bb03c6