Add documentation menu item referencing internal Find Rules page
#2514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigitz
changed the title
Find Rules page
tigitz
changed the title
Find Rules pageFind Rules page
tigitz
force-pushed
the
support-internal-link-in-doc-menu
branch
from
521e041
to
2d19a01
Compare
tigitz
force-pushed
the
support-internal-link-in-doc-menu
branch
from
2d19a01
to
e662325
Compare
|
@TomasVotruba ready to be reviewed 🙂 |
|
Awesome, thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2512
I've introduced a generic view object for the documentation menu item to seamlessly handle both internal link types and documentation section types.
Could handle external link too if needed at some point.