Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle NAs for epicontacts #94

Merged
merged 6 commits into from
Feb 13, 2019
Merged

Handle NAs for epicontacts #94

merged 6 commits into from
Feb 13, 2019

Conversation

zkamvar
Copy link
Member

@zkamvar zkamvar commented Feb 12, 2019

This brings some fixes to #93

  • summary will now print how many missing values are in the contacts from and to
  • as.igraph.epicontacts will now force NAs to be converted to nodes

Bonus:

  • a test that failed because outbreaks got updated was temporarily fixed.

@zkamvar
use get_id in get_degree
6409bab
@zkamvar
add logic to keep NAs in igraph
8cee491
@zkamvar
add test for as.igraph
5dc9f04
@zkamvar
fix test that failed because of outbreaks
b02fa2a 
outbreaks updated a while ago and was only just put on cran
this test now decides to fail. 😡

This is why friends don't let friends use
expect_equal_to_reference()
@zkamvar
update summary to account for missing data
b241716 
this will fix #93
@zkamvar
print dammit
8dfeb79
@zkamvar
Copy link
Member Author

zkamvar commented Feb 13, 2019

Checks are currently failing with appveyor because of package installation issues, but passing with travis. @vpnagraj, does this pass muster?

@vpnagraj vpnagraj merged commit 165abde into master Feb 13, 2019
@vpnagraj
Copy link
Collaborator

awesome! yeah this looks great, thanks for jumping on it ... merged.

moving forward i still want to drop the dplyr dependency (#83) ... so just a heads up that the dplyr::add_row() in 8cee491 will probably change to a base equivalent

@zkamvar zkamvar deleted the contact-handle-na branch February 14, 2019 05:24
@zkamvar zkamvar mentioned this pull request Feb 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zkamvar @vpnagraj