fix issue 11, still needs handling numer approx pb #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
==========================================
- Coverage 91.3% 91.04% -0.26%
==========================================
Files 5 5
Lines 138 134 -4
==========================================
- Hits 126 122 -4
Misses 12 12
Continue to review full report at Codecov.
|
|
It looks good to me. Pretty much what I would have done. I've gone ahead and added a test confirming the boundaries of the likelihood distribution, added NEWS, and bumped the version. |
|
This pull request will open #4 |
zkamvar
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for the log like transformation raised in #11. Test will need fixing but help most welcome, no time here :-/