Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set version to 1.0-draft #179

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Set version to 1.0-draft #179

merged 6 commits into from
Oct 10, 2024

Conversation

wetneb
Copy link
Member

@wetneb wetneb commented Sep 12, 2024

Implementations of the current draft struggle to announce themselves properly because the specs don't specify how they should describe their version in the versions field of the manifest.

This:

  • adjusts the specs so that the 1.0-draft version is specified as such a value
  • also changes the URL (with a redirection) so that the version is clear from there
  • updates the JSON schema to require this value to be present
  • updates the JSON examples accordingly

The choice of 1.0-draft was the consensus that arose from today's meeting, considering that

  • we have made quite a lot of breaking changes since 0.2 so it's worth signifying that
  • we don't intend to make much more versions than this so it feels appropriate to aim for a 1.0 soon

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for reconciliation-api-specs ready!

Name Link
🔨 Latest commit c6bfcdf
🔍 Latest deploy log https://app.netlify.com/sites/reconciliation-api-specs/deploys/66e867a339dd9c0008dca92f
😎 Deploy Preview https://deploy-preview-179--reconciliation-api-specs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

1.0-draft/index.html Outdated Show resolved Hide resolved
1.0-draft/index.html Outdated Show resolved Hide resolved
draft/index.html Outdated Show resolved Hide resolved
Co-authored-by: Fabian Steeg <[email protected]>
@fsteeg fsteeg merged commit d2d1050 into master Oct 10, 2024
5 checks passed
@fsteeg fsteeg deleted the set_version_to_1.0-draft branch October 10, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants