-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Notebook Unit Tests #1538
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
This reverts commit 84d83e2.
Codecov Report
@@ Coverage Diff @@
## staging #1538 +/- ##
===========================================
- Coverage 62.12% 62.07% -0.06%
===========================================
Files 84 84
Lines 8397 8492 +95
===========================================
+ Hits 5217 5271 +54
- Misses 3180 3221 +41
Continue to review full report at Codecov.
|
Description
To improve developer experience working with this repo, we will begin migrating our DevOps pipelines into Github Action, leveraging popular DevOps tools like tox and flake8. This will be a sequence of updates to our DevOps infrastructures:
Propose and draft the CI pipeline in Github ActionSetup self-hosted machines to run our GPU workloadsCreate feature parity with the existing CI pipelines (pr-gates & nightly-build)Run tests on the appropriate dependency subsetsIn this PR:
The idea behind this PR is to use a smaller synthetic dataset to run our notebook unit tests.
This brings two advantages:
Changes:
MockMovielensSchema
class for data synthesisload_spark_df
andload_pandas_df
fromrecommenders.datasets.movielens
Optimization results (offline experiment):
Optimization results (github action):
pr-gate from the latest successful commit:
with the current changes:
Reduce a little more than 66% of the build time 😃 .
Related Issues
#1507
Checklist:
staging branch
and not tomain branch
.