fix: support features #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
==========================================
- Coverage 82.80% 82.73% -0.08%
==========================================
Files 52 52
Lines 5648 5648
==========================================
- Hits 4677 4673 -4
- Misses 971 975 +4
☔ View full report in Codecov by Sentry. |
prestwich
requested changes
Jul 30, 2023
prestwich
approved these changes
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some support features fail to compile when on "default_features = false" because they don't enable "alloc".
This wasn't caught by CI because running "--all-targets" implicitly enables "std" due to the self-dependency (ruint depends on ruint as a dev-dependency with extra features enabled).
Solution
PR Checklist