Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't run tests twice in coverage #278

Merged
merged 1 commit into from
Jul 29, 2023
Merged

Conversation

DaniPopes
Copy link
Contributor

@DaniPopes DaniPopes commented Jul 27, 2023

Motivation

Build only step is unnecessary because we already have it in the tests CI, and also it runs the tests without a convenient way (that I know of) to only build them, so remove it.
Also it runs

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (e34200e) 82.74% compared to head (623c297) 82.73%.
Report is 2 commits behind head on main.

❗ Current head 623c297 differs from pull request most recent head ef9ef16. Consider uploading reports for the commit ef9ef16 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
- Coverage   82.74%   82.73%   -0.02%     
==========================================
  Files          52       52              
  Lines        5588     5588              
==========================================
- Hits         4624     4623       -1     
- Misses        964      965       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prestwich prestwich enabled auto-merge July 29, 2023 22:30
@prestwich prestwich merged commit 9c44aa8 into recmo:main Jul 29, 2023
11 checks passed
@DaniPopes DaniPopes deleted the fix-cov branch July 29, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants