Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volume booster above 100% #1444

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

Luna712
Copy link
Contributor

@Luna712 Luna712 commented Dec 29, 2024

Resolves #1086

@Luna712 Luna712 marked this pull request as draft December 29, 2024 22:32
@Luna712 Luna712 marked this pull request as ready for review December 30, 2024 22:28
@Luna712
Copy link
Contributor Author

Luna712 commented Dec 30, 2024

This should be ready for review now...

@Luna712 Luna712 mentioned this pull request Jan 2, 2025
3 tasks
Copy link
Collaborator

@fire-light42 fire-light42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only tested this briefly so more bugs might be found later. However at the moment you have two critical bugs that I require you to fix.

  1. The showtoast is spammed when dragging over from under 100% to 100%. This might not seem like an issue to you depending on your OS, but for me it flickers.
  2. The color of the left bar even when under 100% is slightly more yellow/orange then the right brightness bar.

@Luna712
Copy link
Contributor Author

Luna712 commented Jan 4, 2025

I have only tested this briefly so more bugs might be found later. However at the moment you have two critical bugs that I require you to fix.

  1. The showtoast is spammed when dragging over from under 100% to 100%. This might not seem like an issue to you depending on your OS, but for me it flickers.
  2. The color of the left bar even when under 100% is slightly more yellow/orange then the right brightness bar.

@fire-light42

Both those should be fixed although I couldn't really reproduce the first one.

@fire-light42
Copy link
Collaborator

Issue two is fixed, but issue one remain. I recommend to look at the log in android studio as showToast should print out repeatedly.

@fire-light42
Copy link
Collaborator

While issue two is fixed, I would much rather you make the background progress of the orange bar invisible so it does not change the white background color at all above 100%.

@Luna712
Copy link
Contributor Author

Luna712 commented Jan 5, 2025

While issue two is fixed, I would much rather you make the background progress of the orange bar invisible so it does not change the white background color at all above 100%.

I tried numerous ways to do this and nothing seemed to work. Only thing that did work was a new drawable but I don't want to do that here,

@Luna712
Copy link
Contributor Author

Luna712 commented Jan 5, 2025

Issue two is fixed, but issue one remain. I recommend to look at the log in android studio as showToast should print out repeatedly.

I decided to just have toasts show once as they get annoying anyway if you change volume a lot, and I think you can get the point after the first time anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow increasing volume over 100%
2 participants