-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add volume booster above 100% #1444
base: master
Are you sure you want to change the base?
Conversation
This should be ready for review now... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only tested this briefly so more bugs might be found later. However at the moment you have two critical bugs that I require you to fix.
- The showtoast is spammed when dragging over from under 100% to 100%. This might not seem like an issue to you depending on your OS, but for me it flickers.
- The color of the left bar even when under 100% is slightly more yellow/orange then the right brightness bar.
Both those should be fixed although I couldn't really reproduce the first one. |
Issue two is fixed, but issue one remain. I recommend to look at the log in android studio as showToast should print out repeatedly. |
While issue two is fixed, I would much rather you make the background progress of the orange bar invisible so it does not change the white background color at all above 100%. |
I tried numerous ways to do this and nothing seemed to work. Only thing that did work was a new drawable but I don't want to do that here, |
…ime and they can get annoying + bug prone
I decided to just have toasts show once as they get annoying anyway if you change volume a lot, and I think you can get the point after the first time anyway. |
Resolves #1086