Add go to downloads button in home if there is no connection #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire-light42
requested changes
Dec 29, 2024
| @@ -590,7 +592,16 @@ class HomeFragment : Fragment() { | |||
|
|
|||
| is Resource.Failure -> { | |||
| homeLoadingShimmer.stopShimmer() | |||
| resultErrorText.text = data.errorString | |||
| var errorString = data.errorString | |||
| if (context?.isNetworkAvailable() == false) { | |||
There was a problem hiding this comment.
Just use isNetworkError or extend the Resource.Failure and check the exception type of the error. This is because isNetworkAvailable is not always correct.
There was a problem hiding this comment.
That actually seems to be more inaccurate though. IE if DNS fails but you actually have connection it is the same error as it is a network error, whereas what I currently use does it only if device has no service.
|
Cant you just always show the "go to downloads instead" button, no matter the error? |
Could but what I wanted to avoid is the open in browser button if no connection as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.