refactor: overall navigation mechanism and split logic #1429 #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
@fire-light42 weird bug in app itself irrespective of this pr, i was testing sdk 35 and turns out the enter animations in settings never work in debug version only release build. |
# Conflicts: # .github/workflows/build_to_archive.yml # .github/workflows/generate_dokka.yml # .github/workflows/issue_action.yml # .github/workflows/prerelease.yml # .github/workflows/pull_request.yml # .github/workflows/update_locales.yml # app/build.gradle.kts
# Conflicts: # app/build.gradle.kts
fire-light42
requested changes
Jan 4, 2025
|
fixed, idk how build to archive got rewritten same |
|
This will be merged in a couple of days, after I have tested it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added smol safedebounce to prevent intentional || unintentional rapid transitions
upgrade coil, navigation and desugar
properly name easter egg activity
dedicated function for opening activities outside nav graph
support for adding custom tag in log error utility (optional)
better navigate function
the reason for replacing appcompat activity with component activity is that it is slightly lightweight, although main activity cant be turned unless compose is used
removed old unused animations
this pr is like a general improvement