metaproviders: use new* methods

[Luna712]

No description provided.

[fire-light42]

I will leave this to be merged before stable as it changes MainAPI. You can also change some other vals to vars like LiveSearchResponse::lang to reduce the number of times of breaking MainAPI changes.

[Luna712]

I will leave this to be merged before stable as it changes MainAPI. You can also change some other vals to vars like LiveSearchResponse::lang to reduce the number of times of breaking MainAPI changes.

Would changing a val to a var really break MainAPI at all though? I thought that was kinda interchangeable when using val to var just not var to val?

[fire-light42]

I will leave this to be merged before stable as it changes MainAPI. You can also change some other vals to vars like LiveSearchResponse::lang to reduce the number of times of breaking MainAPI changes.

Would changing a val to a var really break MainAPI at all though? I thought that was kinda interchangeable when using val to var just not var to val?

It will break extentions on stable that are using prerelease jar as target. To explain why, look at how var generates a set and get function, while val only generates a getter. Any prerelease code running on stable will call the setter and generate an NoSuchMethodError. Look at https://godbolt.org/z/8r5oW98n6

[Luna712]

I will leave this to be merged before stable as it changes MainAPI. You can also change some other vals to vars like LiveSearchResponse::lang to reduce the number of times of breaking MainAPI changes.

Would changing a val to a var really break MainAPI at all though? I thought that was kinda interchangeable when using val to var just not var to val?

It will break extentions on stable that are using prerelease jar as target. To explain why, look at how var generates a set and get function, while val only generates a getter. Any prerelease code running on stable will call the setter and generate an NoSuchMethodError. Look at https://godbolt.org/z/8r5oW98n6

Thank you that is very good to know.