Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow increasing volume over 100% #1086

Open
3 tasks done
BrownNPC opened this issue May 10, 2024 · 3 comments · May be fixed by #1444
Open
3 tasks done

Allow increasing volume over 100% #1086

BrownNPC opened this issue May 10, 2024 · 3 comments · May be fixed by #1444
Labels
enhancement New feature or request

Comments

@BrownNPC
Copy link

Describe your suggested feature

A few videos have low volume. A toggle could be added to the player settings that removed the 100% limit. It would make the user experience better.

Other details

Vlc cannot be used for most videos , because the https stream gets blocked on it. What i'm trying to say is "Just use vlc" is not a valid option.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@BrownNPC BrownNPC added the enhancement New feature or request label May 10, 2024
@Blatzar
Copy link
Contributor

Blatzar commented May 11, 2024

What i'm trying to say is "Just use vlc" is not a valid option.

😐 😐 😐 😐 😐 😐 😐 😐

google/ExoPlayer#5282 (comment) was the best I could find and it does not seem unnecessarily complex.

@Luna712
Copy link
Contributor

Luna712 commented Jun 24, 2024

I may make an attempt at this. I did have something that partially worked awhile ago actually but I hated my implementation method and would rather bot have it then how I did it so kinda abandoned it, but I may make another better attempt at this again.

@int3debug int3debug mentioned this issue Aug 14, 2024
Closed
2 tasks
@fire-light42 fire-light42 mentioned this issue Dec 16, 2024
Closed
2 tasks
@Luna712 Luna712 linked a pull request Dec 29, 2024 that will close this issue
Open
@Luna712
Copy link
Contributor

Luna712 commented Jan 2, 2025

Just an FYI, I finally completed a PR (#1444) for this after numerous try-fail attempts that both works and (in my opinion) has pretty good UI for displaying boost volume as well. So once that is merged this will be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add volume booster above 100% Luna712/cloudstream
3 participants
@Blatzar @BrownNPC @Luna712