Added properties for several AWS resources #980
Conversation
der-eismann
changed the title
There was a problem hiding this comment.
Hey @nwmqpa! Sorry for the late reply. Are you still interested in getting your changes in? It would be great if you could implement my suggestions then.
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
There was a problem hiding this comment.
| if err != nil { | |
| return nil, err | |
| } |
I think this was a copy-paste error
| func (e *IAMSAMLProvider) Properties() types.Properties { | ||
| properties := types.NewProperties() | ||
| return properties | ||
| } | ||
|
|
There was a problem hiding this comment.
This should have one property at least
| func (s *SFNStateMachine) Properties() types.Properties { | ||
| properties := types.NewProperties() | ||
|
|
||
| properties.Set("Name", s.name) |
There was a problem hiding this comment.
This should have the ARN as well
der-eismann
added
the
status/waiting-reponse
|
Hey @der-eismann, I'll try to implement those soon |
|
@nwmqpa due to the size and the number of resources touched here and that the fork as since diverged a bit, I cannot pull these over cleanly. If you'd like to open a PR on https://github.com/ekristen/aws-nuke it would be welcome, please read the contributing guide over there. Otherwise, It's on my backlog to add properties to all resources. Thanks. Please see the copy of the notice from the README about the deprecation of this project. Sven was kind enough to grant me access to help triage and close issues and pull requests that have already been addressed in the actively maintained fork. Some additional information is located in the welcome issue for more information. Caution This repository for aws-nuke is no longer being actively maintained. We recommend users to switch to the actively maintained fork of this project at ekristen/aws-nuke. |
No description provided.