Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extra): add emacs port of dragon and lotus theme #151

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Szkered
Copy link

@Szkered Szkered commented May 18, 2023

No description provided.

@Szkered Szkered changed the title add emacs port of dragon and lotus theme feat:extra add emacs port of dragon and lotus theme May 18, 2023
@Szkered Szkered changed the title feat:extra add emacs port of dragon and lotus theme feat(extra): add emacs port of dragon and lotus theme May 18, 2023
@dzoidbrg
Copy link

Hi! I have a question! How do you use these themes on doom emacs? I have tried installing the original kanagawa-theme.el in the .doom/themes folder and then running m-x/load-themes to load it;however, then I get colors which look weird to me. (I have kangawa installed on nvim and it looks very different). Did I make a mistake in installing the themes? I am asking this, because I have tried for months to get this working and I have found no place to ask about the kanagawa-el theme.

@dzoidbrg
Copy link

dzoidbrg commented May 18, 2023

screenshot
This is how my emacs looks like with the kanagawa-el theme

@dzoidbrg
Copy link

dzoidbrg commented May 18, 2023

screenshot
This is how my nvim looks like.
Is the emacs theme supposed to look like that or did I misconfigure something. Sorry again for asking here, but I have no other place to ask about the kanagawa theme other than this PR.

@Szkered
Copy link
Author

Szkered commented May 18, 2023

And are you using the original kanagawa-wave theme? Did you install autothemer ? Let me know what programming language you are using so I can test it.

@dzoidbrg
Copy link

OK thanks! I am using this as theme https://github.com/rebelot/kanagawa.nvim/blob/master/extras/kanagawa-theme.el. I am using rust as a programming language. I will double check if I have autothemer installed

@dzoidbrg
Copy link

Yes, I have it installed. On my emacs side, I have tree-sitter installed, and I just ran load-theme to load kanagawa-theme-el.
If you wish, I can post my doom emacs config

@dzoidbrg
Copy link

Can you maybe post a screenshot of one of your kanagawa-themes or the original one with any language so I can see if it is maybe a emacs font or color config problem on my side. Also, thank you so much for helping me with my issue!

@Szkered
Copy link
Author

Szkered commented May 19, 2023

I tested the theme with some rust code, and I am getting similar result as yours. I think the palette is not 100% aligned with the original kanagawa theme in nvim. If you want to get exactly the same coloring maybe you could try to align them yourself. In emacs, you can find out what is setting the color of a certain text by calling describe-face with your cursor hovering the text. For example you could get something like tree-sitter-hl-face:type. Then you can edit the kanagawa-theme.el file to make the theme matches the original.

@dzoidbrg
Copy link

OK thank you! I just want to know, that it is not a configuration error on my part! I mean, I do quite like it, so I will tune the emacs theme to my needs, but thank you for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants