Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump glodrei to its successor react-three/drei #256

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

wey-gu
Copy link
Contributor

@wey-gu wey-gu commented Jul 25, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Other... Please describe:

We hit issue when working with some other packages with react-three/drei(the new name of glodrei)

./node_modules/glodrei/core/useSpriteLoader.js
Attempted import error: 'sRGBEncoding' is not exported from 'three' (imported as 'THREE').

What is the current behavior?

As above

Issue Number: N/A

What is the new behavior?

Now it's back normal.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reagraph ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 1:12pm

Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for reagraph ready!

Name Link
🔨 Latest commit 622ef27
🔍 Latest deploy log https://app.netlify.com/sites/reagraph/deploys/66a24f017fcb8c0008b58dc4
😎 Deploy Preview https://deploy-preview-256--reagraph.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amcdnl amcdnl merged commit b73671d into reaviz:master Jul 25, 2024
7 checks passed
@wey-gu
Copy link
Contributor Author

wey-gu commented Jul 25, 2024

@amcdnl sorry, I found with this change, the drag is not working, I just rolled back with the previous one, and it turned out the key issue in my project was due to multiple threejs versions && a version of threejs is not working properly (167) so I pinned to 154 and things are perfect now.

Sorry for bringing the trouble.

really loved reagraph(not a fe dev, reagraph is just elegant and extremely polished)

@amcdnl
Copy link
Member

amcdnl commented Jul 25, 2024

@wey-gu - Thank you very much! Do we need to revert this PR?

@wey-gu wey-gu deleted the wey/react-three/drei branch July 25, 2024 17:56
@wey-gu
Copy link
Contributor Author

wey-gu commented Jul 25, 2024

@wey-gu - Thank you very much! Do we need to revert this PR?

Yes, please! Sorry again!

@dmurvihill
Copy link

dmurvihill commented Oct 1, 2024

This change is needed. Glodrei looks for sure like it's been superseded by drei and it's starting to cause trouble e.g. with #278 which is fixed in drei. Pinning three downstream is a workaround, not a fix.

Glodrei is also on an old version of Zustand (v3) and using an old syntax that's emitting deprecation warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants