add extended Theme support for Edge and Node #145
Conversation
| @@ -51,10 +53,32 @@ export interface GraphNode extends GraphElementBaseAttributes { | |||
| * Fill color for the node. | |||
| */ | |||
| fill?: string; | |||
| theme?: { | |||
There was a problem hiding this comment.
You should be able to access the theme via the hook.
| @@ -60,6 +82,23 @@ export interface GraphEdge extends GraphElementBaseAttributes { | |||
| * Target ID of the node. | |||
| */ | |||
| target: string; | |||
|
|
|||
| theme?: { | |||
There was a problem hiding this comment.
You should be able to access the theme via the hook.
| */ | ||
| fill?: string; | ||
| theme?: { |
There was a problem hiding this comment.
You should be able to access the theme via the hook.
| @@ -46,8 +46,30 @@ export interface GraphNode extends GraphElementBaseAttributes { | |||
|
|
|||
| /** | |||
| * Fill color for the node. | |||
| * @deprecated use theme.fill | |||
| */ | |||
| fill?: string; | |||
There was a problem hiding this comment.
Kinda have to keep this for node specific colors though we could extend it to support a callback.
|
@AnWeber - Happy to merge if you can resolve some of those items. |
@amcdnl I can gladly incorporate the comments, but I don't directly understand what I should change and how. What do you mean by mentioning |
|
Going to close this for now given the conflicts. I'm still happy to accept this we just need to make sure the pattern follows. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What is the current behavior?
only Node specific fill Color is supported
Issue Number: N/A
What is the new behavior?
Different colors for fill, activeFill,... can be defined for each node and edge
add extended support for Node and Edge specific Theme support
GraphNodeGraphEdgefillProperty inGraphNode(Hint to node.theme.fill added)Does this PR introduce a breaking change?
I would deprecated previous fill Property. If this is not intended, deprecation hints can be removed