Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve function body braces #2223

Merged

Commits on Oct 9, 2018

  1. Preserve function body braces

    This is an alternative to reasonml#1826 implementing just the brace preservation
    code, to make it easier to be reviewed.
    
    I think this is now in a better place to get into the codebase given
    that we have `Reason_attributes` outside of `Reason_pprint_ast` and that
    we now remove our own attributes before printing to OCaml.
    
    I think we can probably refactor this code further in future PRs, as
    well as add other stylistic preservation changes.
    anmonteiro committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    7154796 View commit details
    Browse the repository at this point in the history
  2. Rebase and fix

    anmonteiro committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    c7182e4 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2018

  1. address review comments

    anmonteiro committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    b095008 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2018

  1. Configuration menu
    Copy the full SHA
    373ed5f View commit details
    Browse the repository at this point in the history