fix: record constraint pattern

reasonml · Oct 5, 2023 · 9120ad5 · 9120ad5
1 parent f92f7ec
commit 9120ad5
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 9 deletions.
diff --git a/flake.lock b/flake.lock
diff --git a/src/reason-parser/reason_pprint_ast.ml b/src/reason-parser/reason_pprint_ast.ml
@@ -5760,7 +5760,16 @@ let printer = object(self:'self)
           (* works with module prefix too: {ReasonReact.state: state as prevState} becomes {ReasonReact.state as prevState *)
             makeList ~sep:(Sep " ") [self#longident_loc li; atom "as"; atom aliasIdent]
         | _ ->
-            label ~space:true (makeList [self#longident_loc li; atom ":"]) (self#pattern p)
+            let pattern =
+              let formatted = self#pattern p in
+              let wrap =
+                match p.ppat_desc with
+                | Ppat_constraint (_, _) -> Some("(", ")")
+                | _ -> None
+              in
+              makeList ~inline:(true, true) ?wrap [ formatted ]
+            in
+            label ~space:true (makeList [self#longident_loc li; atom ":"]) pattern
     in
     let rows = (List.map longident_x_pattern l)@(
       match closed with

diff --git a/test/wrapping-re.t/input.re b/test/wrapping-re.t/input.re
@@ -1486,7 +1486,7 @@ let funcOnSomeRecord
 
 /* With two args */
 let funcOnSomeConstructorHi
-    (SomeConstructorHi(x,y), secondArg) = 
+    (SomeConstructorHi(x,y), secondArg) =
   x + y;
 
 let funcOnSomeRecord
@@ -1982,3 +1982,6 @@ fooSpreadES6List([
   "more tests",
   ...x
 ]);
+
+let { foo: (_: int), } = 2;
+
diff --git a/test/wrapping-re.t/run.t b/test/wrapping-re.t/run.t
@@ -2904,3 +2904,5 @@ Format wrapping in .re files
     "more tests",
     ...x,
   ]);
+
+  let {foo: (_: int)} = 2;