Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refmt errors destroy code #91

Open
dvisztempacct opened this issue May 10, 2018 · 3 comments
Open

Refmt errors destroy code #91

dvisztempacct opened this issue May 10, 2018 · 3 comments

Comments

@dvisztempacct
Copy link
Contributor

When the refmt fails, the code is replaced by error messages.

My colleagues and I do not like this behavior. We'd rather see the original content than refmt errors!
@dvisztempacct
Copy link
Contributor Author

dvisztempacct commented May 11, 2018 •
edited
Loading

I'm seeking feedback on a PR which addresses this issue:

#92

@ELLIOTTCABLE
Copy link

👍 on this. The webmachine documentation was left basically unreadable by this:

image

I was really excited when I found this addon; unfortunately, looks like it needs a little love.

@dvisztempacct your link is broken!

@ELLIOTTCABLE ELLIOTTCABLE mentioned this issue Jul 17, 2018
Merged
@dvisztempacct
Copy link
Contributor Author

@ELLIOTTCABLE fixed :)

The PR was merged and accomplishes most of my objective. Maybe this issue can be closed?

Do we want to keep this issue around to discuss how error handling can be further improved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ELLIOTTCABLE @dvisztempacct