RCOCOA-2343 Enable building RealmSwift as a dynamic framework with SPM #8561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoyne
changed the title
tgoyne
force-pushed
the
tg/force-dynamic
branch
from
078c443
to
790366e
Compare
tgoyne
changed the title
|
This appears to work but the process for validating app privacy manifests is so awful that it's hard to be sure. |
nirinchev
approved these changes
Apr 30, 2024
dianaafanador3
approved these changes
Apr 30, 2024
| - To actually build RealmSwift as a dynamic framework, change "Do Not Embed" | ||
| to "Embed & Sign" in the "Frameworks, Libraries, and Embedded Content" | ||
| section on the General tab of your target's settings. | ||
| ([#8561](https://github.com/realm/realm-swift/pull/8561)). |
There was a problem hiding this comment.
Should we tag the docs teams for this to be added to this page? https://www.mongodb.com/docs/atlas/device-sdks/sdk/swift/install/
| libraries in a way compatible with xcprivacy embedding. Due to some bugs in | ||
| Xcode, this may require manual changes to your project: | ||
| - Targets must now depend on only Realm or RealmSwift. If you use both the | ||
| obj-c and swift API, depending on RealmSwift will let you import Realm. |
There was a problem hiding this comment.
This means, that by importing RealmSwift, user will have access to Realm API
There was a problem hiding this comment.
No, Realm is still a separate import. They just don't have to add it as a dependency in the project.
This is required for compliance with the new privacy manifest rules. While App Store Connect supports static libraries, Xcode doesn't actually build static libraries for static targets; it just links the object files directly into the app. It also doesn't implement the xcprivacy manifest merging that the documentation claims exists, so our privacy manfiest is never actually used.
tgoyne
force-pushed
the
tg/force-dynamic
branch
from
790366e
to
2ca5c82
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While App Store Connect supports static libraries, Xcode doesn't actually build static libraries for static targets; it just links the object files directly into the app. It also doesn't implement the xcprivacy manifest merging that the documentation claims exists, so the only way to actually use our privacy manifest is to build a dynamic framework.
Because Xcode is very weird, setting the library type to
.dynamicdoesn't actually result in it being built as a dynamic framework; it just gives the consuming app the option of building it as dynamic. It also makes it so that having multiple targets depend on the product is broken. Hopefully that will not be a problem.Building Realm.framework as dynamic and then RealmSwift.framework as static doesn't work, so this adds the privacy manifest to RealmSwift.framework as well.