Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add musl linux builds #6807

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Add musl linux builds #6807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5f90e57
test
gagik Jul 23, 2024
e5bc791
fix
gagik Jul 23, 2024
7158320
naming fix
gagik Jul 23, 2024
ac0b90f
fix
gagik Jul 23, 2024
0d7837d
Add musl tag
gagik Jul 23, 2024
5ab8b50
Add libc tag
gagik Jul 23, 2024
a401e86
fix
gagik Jul 23, 2024
ea82e80
Use musl toolchain core
gagik Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions .github/workflows/pr-realm-js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ jobs:
packages/realm/binding/generated

prebuild-node:
name: Prebuild ${{ matrix.os }} ${{ matrix.arch }} (Node.js)
name: Prebuild ${{ matrix.os }} ${{ matrix.arch }}${{ matrix.libc == 'musl' && '-musl' || '' }} (Node.js)
runs-on: ${{ matrix.runner }}
strategy:
fail-fast: false
Expand All @@ -114,9 +114,19 @@ jobs:
- os: linux
runner: ubuntu-latest
arch: arm
libc: gnu
- os: linux
runner: ubuntu-latest
arch: arm
libc: musl
- os: linux
runner: ubuntu-latest
arch: arm64
libc: gnu
- os: linux
runner: ubuntu-latest
arch: arm64
libc: musl
- os: windows
runner: windows-latest
arch: x64
Expand Down Expand Up @@ -209,11 +219,12 @@ jobs:
run: npm run prebuild-node --workspace realm
env:
PREBUILD_ARCH: ${{ matrix.arch }}
REALM_LINUX_LIBC: ${{ matrix.libc }}

- name: Upload prebuild artifact
uses: actions/upload-artifact@v4
with:
name: node-${{ matrix.os }}-${{ matrix.arch }}-prebuild
name: node-${{ matrix.os }}${{ matrix.libc == 'musl' && 'musl' || '' }}-${{ matrix.arch }}-prebuild
# Including README.md to pin paths to the root of the repository
path: |
README.md
Expand Down
2 changes: 1 addition & 1 deletion packages/realm/bindgen/vendor/realm-core
Open in desktop
Submodule realm-core updated 8 files
+23 −0 CHANGELOG.md
+5 −1 tools/cmake/AcquireRealmDependency.cmake
+1 −0 tools/cmake/aarch64-linux-gnu.toolchain.cmake
+4 −0 tools/cmake/aarch64-linux-musl.toolchain.cmake
+1 −0 tools/cmake/armv7-linux-gnueabihf.toolchain.cmake
+9 −0 tools/cmake/armv7-linux-musleabihf.toolchain.cmake
+1 −0 tools/cmake/x86_64-linux-gnu.toolchain.cmake
+4 −0 tools/cmake/x86_64-linux-musl.toolchain.cmake
6 changes: 5 additions & 1 deletion packages/realm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,11 +282,15 @@
]
},
"prebuild-node": {
"command": "cross-env-shell prebuild --runtime napi --arch $PREBUILD_ARCH -- --directory binding/node",
"command": "cross-env-shell prebuild --runtime napi --arch $PREBUILD_ARCH --libc $REALM_LINUX_LIBC -- --directory binding/node",
"env": {
"PREBUILD_ARCH": {
"external": true,
"default": "undefined"
},
"REALM_LINUX_LIBC": {
"external": true,
"default": "undefined"
}
}
},
Expand Down
Loading