Fetch statusText polyfill
#5530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The React Native fetch polyfill fails to provide this. See react-native-community/fetch#14
kraenhansen
changed the title
statusText polyfill
kraenhansen
commented
Mar 2, 2023
Comment on lines
+40
to
+62
| private static createTimeoutSignal(timeoutMs: number | undefined) { | ||
| if (typeof timeoutMs === "number") { | ||
| const controller = new DefaultNetworkTransport.AbortController(); | ||
| // Call abort after a specific number of milliseconds | ||
| const timeout = setTimeout(() => { | ||
| controller.abort(); | ||
| }, timeoutMs); | ||
| return { | ||
| signal: controller.signal, | ||
| cancelTimeout: () => { | ||
| clearTimeout(timeout); | ||
| }, | ||
| }; | ||
| } else { | ||
| return { | ||
| signal: undefined, | ||
| cancelTimeout: () => { | ||
| /* No-op */ | ||
| }, | ||
| }; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I just moved this up to be a static member, since it didn't need access to the instance.
kraenhansen
commented
Mar 2, 2023
Comment on lines
+20
to
+72
| 100: "Continue", | ||
| 101: "Switching Protocols", | ||
| 102: "Processing", | ||
| 200: "OK", | ||
| 201: "Created", | ||
| 202: "Accepted", | ||
| 203: "Non-Authoritative Information", | ||
| 204: "No Content", | ||
| 205: "Reset Content", | ||
| 206: "Partial Content", | ||
| 300: "Multiple Choices", | ||
| 301: "Moved Permanently", | ||
| 302: "Found", | ||
| 303: "See Other", | ||
| 304: "Not Modified", | ||
| 307: "Temporary Redirect", | ||
| 308: "Permanent Redirect", | ||
| 400: "Bad Request", | ||
| 401: "Unauthorized", | ||
| 402: "Payment Required", | ||
| 403: "Forbidden", | ||
| 404: "Not Found", | ||
| 405: "Method Not Allowed", | ||
| 406: "Not Acceptable", | ||
| 407: "Proxy Authentication Required", | ||
| 408: "Request Timeout", | ||
| 409: "Conflict", | ||
| 410: "Gone", | ||
| 411: "Length Required", | ||
| 412: "Precondition Failed", | ||
| 413: "Payload Too Large", | ||
| 414: "URI Too Long", | ||
| 415: "Unsupported Media Type", | ||
| 416: "Range Not Satisfiable", | ||
| 417: "Expectation Failed", | ||
| 418: "I'm a teapot", | ||
| 422: "Unprocessable Entity", | ||
| 425: "Too Early", | ||
| 426: "Upgrade Required", | ||
| 429: "Too Many Requests", | ||
| 431: "Request Header Fields Too Large", | ||
| 451: "Unavailable For Legal Reasons", | ||
| 500: "Internal Server Error", | ||
| 501: "Not Implemented", | ||
| 502: "Bad Gateway", | ||
| 503: "Service Unavailable", | ||
| 504: "Gateway Timeout", | ||
| 505: "HTTP Version Not Supported", | ||
| 506: "Variant Also Negotiates", | ||
| 507: "Insufficient Storage", | ||
| 508: "Loop Detected", | ||
| 510: "Not Extended", | ||
| 511: "Network Authentication Required", |
There was a problem hiding this comment.
There was a problem hiding this comment.
Can you add that as a comment in the code?
takameyer
approved these changes
Mar 3, 2023
Comment on lines
+20
to
+72
| 100: "Continue", | ||
| 101: "Switching Protocols", | ||
| 102: "Processing", | ||
| 200: "OK", | ||
| 201: "Created", | ||
| 202: "Accepted", | ||
| 203: "Non-Authoritative Information", | ||
| 204: "No Content", | ||
| 205: "Reset Content", | ||
| 206: "Partial Content", | ||
| 300: "Multiple Choices", | ||
| 301: "Moved Permanently", | ||
| 302: "Found", | ||
| 303: "See Other", | ||
| 304: "Not Modified", | ||
| 307: "Temporary Redirect", | ||
| 308: "Permanent Redirect", | ||
| 400: "Bad Request", | ||
| 401: "Unauthorized", | ||
| 402: "Payment Required", | ||
| 403: "Forbidden", | ||
| 404: "Not Found", | ||
| 405: "Method Not Allowed", | ||
| 406: "Not Acceptable", | ||
| 407: "Proxy Authentication Required", | ||
| 408: "Request Timeout", | ||
| 409: "Conflict", | ||
| 410: "Gone", | ||
| 411: "Length Required", | ||
| 412: "Precondition Failed", | ||
| 413: "Payload Too Large", | ||
| 414: "URI Too Long", | ||
| 415: "Unsupported Media Type", | ||
| 416: "Range Not Satisfiable", | ||
| 417: "Expectation Failed", | ||
| 418: "I'm a teapot", | ||
| 422: "Unprocessable Entity", | ||
| 425: "Too Early", | ||
| 426: "Upgrade Required", | ||
| 429: "Too Many Requests", | ||
| 431: "Request Header Fields Too Large", | ||
| 451: "Unavailable For Legal Reasons", | ||
| 500: "Internal Server Error", | ||
| 501: "Not Implemented", | ||
| 502: "Bad Gateway", | ||
| 503: "Service Unavailable", | ||
| 504: "Gateway Timeout", | ||
| 505: "HTTP Version Not Supported", | ||
| 506: "Variant Also Negotiates", | ||
| 507: "Insufficient Storage", | ||
| 508: "Loop Detected", | ||
| 510: "Not Extended", | ||
| 511: "Network Authentication Required", |
There was a problem hiding this comment.
Can you add that as a comment in the code?
| 415: "Unsupported Media Type", | ||
| 416: "Range Not Satisfiable", | ||
| 417: "Expectation Failed", | ||
| 418: "I'm a teapot", |
There was a problem hiding this comment.
The HTTP 418 I'm a teapot client error response code indicates that the server refuses to brew coffee because it is, permanently, a teapot. A combined coffee/tea pot that is temporarily out of coffee should instead return 503.
elle-j
approved these changes
Mar 3, 2023
| 415: "Unsupported Media Type", | ||
| 416: "Range Not Satisfiable", | ||
| 417: "Expectation Failed", | ||
| 418: "I'm a teapot", |
There was a problem hiding this comment.
The HTTP 418 I'm a teapot client error response code indicates that the server refuses to brew coffee because it is, permanently, a teapot. A combined coffee/tea pot that is temporarily out of coffee should instead return 503.
kraenhansen
added a commit
that referenced
this pull request
Mar 3, 2023
* This provides a polyfill for the statusText The React Native fetch polyfill fails to provide this. See react-native-community/fetch#14 * Update status-text.ts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This provides a polyfill for the
statusTexton aResponsereturned byfetch.The React Native fetch polyfill fails to provide this.
See react-native-community/fetch#14.