-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use upstream pkl-gha for GitHub Action Workflows #3677
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: StefMa <[email protected]>
Signed-off-by: StefMa <[email protected]>
Realm welcomes all contributions! The only requirement we have is that, like many other projects, we need to have a Contributor License Agreement (CLA) in place before we can accept any external code. Our own CLA is a modified version of the Apache Software Foundation’s CLA. Our records show that CLA has not been signed by @StefMa. Please submit your CLA electronically using our Google form so we can accept your submissions. After signing the CLA you can recheck this PR with a |
pkl eval pkl-workflows/*.pkl -o workflows/%{moduleName}.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this is correct.
Please check this if this still works.
I'm not a Windows user...
Hey @StefMa thanks so much for this - great stuff. I was going to eventually try and submit a PR upstream for those changes, but priority reshuffles within the company meant I don't have that much time working on this project anymore. I'll try and review this over the weekend and get it in. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
@nirinchev what weekned did you mean? 🤔 Just kidding 🙂 |
Hey @StefMa, was just planning to get to it after I put some final touches on the Half Life 3 release - should be out any day now 😝 It's a fair callout - been distracted lately with other things, but will try and make time for it Very Soon™! |
Description
Hello Realm .NET Team 👋
It’s great to see that you’re considering using Pkl, especially pkl-gha, to configure your CI 🙂.
I’ve incorporated all of your additions into the upstream project, so your customizations are no longer necessary.
This means there’s no longer any maintenance overhead required on your end.
I’ve split the PR into three commits:
Each of these commits can be reviewed individually.
Please note that I haven’t changed any of your logic.
I’ve only replaced your implementation with the upstream project.
I hope you find this useful!
Let me know if anything is missing or if there are any improvements I can make to pkl-gha.
Looking forward to your review and feedback 🤝.
cc @nirinchev because you added pkl at the first place here #3603 🙂