Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to new sync error codes #3440

Merged
merged 9 commits into from
Sep 15, 2023
Merged

Migrate to new sync error codes #3440

merged 9 commits into from
Sep 15, 2023

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Sep 14, 2023 •
edited
Loading

Description

Fixes #3295

TODO

  • Changelog entry
  • Tests (if applicable)
  • API docs

@cla-bot cla-bot bot added the cla: yes label Sep 14, 2023
@coveralls-official
Copy link

Pull Request Test Coverage Report for Build 6196214021

  • 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.608%
Totals Coverage Status
Change from base Build 6195342590: 0.0%
Covered Lines: 6314
Relevant Lines: 7723
💛 - Coveralls

@nirinchev nirinchev marked this pull request as ready for review September 15, 2023 10:46
papafe
papafe approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@papafe papafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

Realm/Realm/Exceptions/Sync/ErrorCode.cs
UserMismatch = 1041,

/// <summary>
/// Client attempted a write that is disallowed by permissions, or modifies an object
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we get a compensating write instead?

@nirinchev nirinchev merged commit 11ab212 into main Sep 15, 2023
10 checks passed
@nirinchev nirinchev deleted the ni/sync-errors branch September 15, 2023 15:30
nirinchev added a commit that referenced this pull request Sep 15, 2023
@nirinchev
Merge branch 'main' into ni/user-changed
576d88f 
* main:
  Migrate to new sync error codes (#3440)
  Starting one cluster per platform on CI (#3426)
  Fix trailing comma when there are no features to analyze (#3438)
  Don’t use KeyValuePair in marshaling because it’s overloaded on UWP (#3435)
papafe added a commit that referenced this pull request Sep 25, 2023
@papafe
Merge branch 'main' into fp/mixed-collections plus moved core to next…
943e6d9 
…-major

* main:
  Allow customizing json ignore attribute for serialized classes (#3451)
  Update README.md (#3450)
  Fix changelog
  Prepare for vNext (#3444)
  Prepare for 11.5.0 (#3442)
  Migrate to new sync error codes (#3440)
  Starting one cluster per platform on CI (#3426)
  Fix trailing comma when there are no features to analyze (#3438)

# Conflicts:
#	wrappers/realm-core
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@papafe papafe papafe approved these changes

@fealebenpae fealebenpae fealebenpae approved these changes

Assignees

@nirinchev nirinchev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync Client Error Simplification
3 participants
@nirinchev @fealebenpae @papafe