Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starting one cluster per platform on CI #3426

Merged
merged 19 commits into from
Sep 15, 2023
Merged

Starting one cluster per platform on CI #3426

merged 19 commits into from
Sep 15, 2023

Conversation

papafe
Copy link
Contributor

@papafe papafe commented Aug 17, 2023

Fixes #3423

@cla-bot cla-bot bot added the cla: yes label Aug 17, 2023
@papafe papafe added the no-changelog Used to skip the changelog check label Aug 17, 2023
@papafe papafe changed the title [DRAFT] Starting one cluster per run on CI [DRAFT] Starting one cluster per platform on CI Aug 17, 2023
@papafe papafe requested a review from nirinchev August 23, 2023 07:11
@papafe papafe changed the title [DRAFT] Starting one cluster per platform on CI Starting one cluster per platform on CI Aug 23, 2023
@papafe
Copy link
Contributor Author

papafe commented Aug 23, 2023

It seems that this is working properly. I'm not sure about Android though, because it seems the timeout is not respected, I suppose there is a timeout inside the device farm?

nirinchev
nirinchev reviewed Aug 29, 2023
View reviewed changes
Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have a few minor questions/suggestions where I was too lazy to check this for myself 😄

.github/workflows/deploy-baas.yml Show resolved Hide resolved
.github/workflows/test-macos.yml Outdated Show resolved Hide resolved
Tools/DeployApps/BaasClient.cs Show resolved Hide resolved
Tools/DeployApps/BaasClient.cs Outdated Show resolved Hide resolved
.github/templates/build.lib.yml Show resolved Hide resolved
@papafe papafe marked this pull request as ready for review September 5, 2023 07:24
@papafe papafe merged commit 1efc569 into main Sep 15, 2023
116 of 125 checks passed
@papafe papafe deleted the fp/ci branch September 15, 2023 07:45
nirinchev added a commit that referenced this pull request Sep 15, 2023
@nirinchev
Merge branch 'main' into ni/sync-errors
f83bfe9 
* main:
  Starting one cluster per platform on CI (#3426)
nirinchev added a commit that referenced this pull request Sep 15, 2023
@nirinchev
Merge branch 'main' into ni/user-changed
576d88f 
* main:
  Migrate to new sync error codes (#3440)
  Starting one cluster per platform on CI (#3426)
  Fix trailing comma when there are no features to analyze (#3438)
  Don’t use KeyValuePair in marshaling because it’s overloaded on UWP (#3435)
papafe added a commit that referenced this pull request Sep 25, 2023
@papafe
Merge branch 'main' into fp/mixed-collections plus moved core to next…
943e6d9 
…-major

* main:
  Allow customizing json ignore attribute for serialized classes (#3451)
  Update README.md (#3450)
  Fix changelog
  Prepare for vNext (#3444)
  Prepare for 11.5.0 (#3442)
  Migrate to new sync error codes (#3440)
  Starting one cluster per platform on CI (#3426)
  Fix trailing comma when there are no features to analyze (#3438)

# Conflicts:
#	wrappers/realm-core
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nirinchev nirinchev nirinchev left review comments

Assignees

@papafe papafe

Labels
cla: yes no-changelog Used to skip the changelog check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix timeouts on CI
2 participants
@papafe @nirinchev