Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Platform Networking #3412
Platform Networking #3412
Changes from 3 commits
0513a4f
ddc3c1c
f29e7d8
45bba6a
0d85c3a
fc61000
b59669d
3735878
8c201eb
0b3ed53
410708d
415eff0
877efce
5c6cb46
beb2b4a
1ed614d
c4d7dd1
6f0282d
4eb5a63
9bddaf6
3d23531
daaeac4
8c532d4
01442cc
6440e78
a194522
104da2c
bf2af73
b5a21cd
ac40766
092b8ef
e3e50ba
55376df
9b14717
771d029
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 35 in Realm/Realm/Native/SyncSocketProvider.WebSocket.cs
GitHub Actions / Test / Weaver (macos-latest, osx-x64)
Check warning on line 35 in Realm/Realm/Native/SyncSocketProvider.WebSocket.cs
GitHub Actions / Test / Weaver (windows-latest, win-x64)
Check warning on line 35 in Realm/Realm/Native/SyncSocketProvider.WebSocket.cs
GitHub Actions / Package / NuGet
Check warning on line 43 in Realm/Realm/Native/SyncSocketProvider.WebSocket.cs
GitHub Actions / Test / Weaver (macos-latest, osx-x64)
Check warning on line 43 in Realm/Realm/Native/SyncSocketProvider.WebSocket.cs
GitHub Actions / Test / Weaver (windows-latest, win-x64)
Check warning on line 43 in Realm/Realm/Native/SyncSocketProvider.WebSocket.cs
GitHub Actions / Package / NuGet
Check warning on line 58 in Realm/Realm/Native/SyncSocketProvider.WebSocket.cs
GitHub Actions / Test / Weaver (macos-latest, osx-x64)
Check warning on line 58 in Realm/Realm/Native/SyncSocketProvider.WebSocket.cs
GitHub Actions / Test / Weaver (windows-latest, win-x64)
Check warning on line 58 in Realm/Realm/Native/SyncSocketProvider.WebSocket.cs
GitHub Actions / Package / NuGet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we send a websocket closed work in case of a non-websocket error - e.g. I can imagine we can hit an out of memory or similar system exception that would prevent us from connecting but Sync will be waiting forever for the connection.
Check warning on line 60 in Realm/Realm/Native/SyncSocketProvider.WebSocket.cs
GitHub Actions / Verify TODOs
Realm/Realm/Native/SyncSocketProvider.WebSocket.cs#L60
Check warning on line 85 in Realm/Realm/Native/SyncSocketProvider.WebSocket.cs
GitHub Actions / Test / Weaver (macos-latest, osx-x64)
Check warning on line 85 in Realm/Realm/Native/SyncSocketProvider.WebSocket.cs
GitHub Actions / Test / Weaver (windows-latest, win-x64)
Check warning on line 85 in Realm/Realm/Native/SyncSocketProvider.WebSocket.cs
GitHub Actions / Package / NuGet
Check warning on line 87 in Realm/Realm/Native/SyncSocketProvider.WebSocket.cs
GitHub Actions / Verify TODOs
Realm/Realm/Native/SyncSocketProvider.WebSocket.cs#L87
Check warning on line 89 in Realm/Realm/Native/SyncSocketProvider.WebSocket.cs
GitHub Actions / Test / Weaver (macos-latest, osx-x64)
Check warning on line 107 in Realm/Realm/Native/SyncSocketProvider.WebSocket.cs
GitHub Actions / Verify TODOs
Realm/Realm/Native/SyncSocketProvider.WebSocket.cs#L107