Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RCPP-64 Don't use symbolic links in include folder #192

Merged
merged 9 commits into from
Apr 8, 2024
Merged

RCPP-64 Don't use symbolic links in include folder #192

merged 9 commits into from
Apr 8, 2024

Conversation

leemaguire
Copy link
Contributor

Fixes: #191

@leemaguire leemaguire self-assigned this Apr 3, 2024
@leemaguire leemaguire marked this pull request as ready for review April 4, 2024 08:22
@leemaguire leemaguire requested a review from fealebenpae April 4, 2024 08:22
@fealebenpae
Copy link
Member

Could you please move the header files with git mv instead? That should preserve the history of the files and make for a much smaller commit.

@leemaguire leemaguire merged commit 8e55af0 into main Apr 8, 2024
55 of 57 checks passed
@leemaguire leemaguire deleted the lm/includes branch April 8, 2024 13:14
@leemaguire leemaguire mentioned this pull request Apr 17, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fealebenpae fealebenpae fealebenpae approved these changes

Assignees

@leemaguire leemaguire

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows build error with 1.1.0
2 participants
@leemaguire @fealebenpae