Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCORE-2180 Add basic translation of NSExceptions to Status #8010

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

tgoyne
Copy link
Member

@tgoyne tgoyne commented Aug 29, 2024

When the Swift API is misused from within a callback from core a NSException may escape, which we want to propagate. Since this is always a fatal error that cannot be programmatically handled by the user, we can always translate this to UnknownError rather than trying to preserve the original error code.

Fixes #7836.

When the Swift API is misused from within a callback from core a NSException
may escape, which we want to propagate. Since this is always a fatal error that
cannot be programmatically handled by the user, we can always translate this to
UnknownError rather than trying to preserve the original error code.
@tgoyne tgoyne self-assigned this Aug 29, 2024
@cla-bot cla-bot bot added the cla: yes label Aug 29, 2024
Copy link

Pull Request Test Coverage Report for Build thomas.goyne_495

Details

  • 26 of 27 (96.3%) changed or added relevant lines in 2 files are covered.
  • 65 unchanged lines in 19 files lost coverage.
  • Overall coverage decreased (-0.003%) to 91.114%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/realm/exceptions.mm 16 17 94.12%
Files with Coverage Reduction New Missed Lines %
src/realm/array_backlink.cpp 1 91.38%
src/realm/dictionary.cpp 1 85.16%
src/realm/sort_descriptor.cpp 1 94.06%
src/realm/util/file.cpp 1 84.84%
src/realm/util/serializer.cpp 1 90.43%
test/test_dictionary.cpp 1 99.83%
src/realm/query_expression.hpp 2 93.81%
src/realm/table_view.cpp 2 92.99%
src/realm/sync/client.cpp 3 90.96%
src/realm/sync/noinst/protocol_codec.hpp 3 75.74%
Totals Coverage Status
Change from base Build 2589: -0.003%
Covered Lines: 217379
Relevant Lines: 238580

💛 - Coveralls

@tgoyne tgoyne merged commit f9e36f7 into master Aug 30, 2024
49 checks passed
@tgoyne tgoyne deleted the tg/nsexception branch August 30, 2024 01:09
@github-actions github-actions bot mentioned this pull request Aug 30, 2024
@jedelbo jedelbo mentioned this pull request Sep 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling foundSubscription.updateQuery throws unhandled exception
2 participants