RCORE-2242: Include pathname in exception thrown in File::rw_lock #8000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build jorgen.edelbo_421Details
💛 - Coveralls |
jbreams
reviewed
Aug 27, 2024
src/realm/util/file.cpp
Outdated
| @@ -1152,6 +1152,11 @@ bool File::rw_lock(bool exclusive, bool non_blocking) | |||
| // or the OS will deadlock when un-suspending the app. | |||
| int mode = exclusive ? O_WRONLY | O_NONBLOCK : O_RDWR | O_NONBLOCK; | |||
|
|
|||
| auto report_err = [path = m_fifo_path](int err, const char* msg) { | |||
There was a problem hiding this comment.
Should we worry about the cost of copying this string here?
There was a problem hiding this comment.
I don't see any reason for this to not just capture [this].
| @@ -1152,6 +1152,11 @@ bool File::rw_lock(bool exclusive, bool non_blocking) | |||
| // or the OS will deadlock when un-suspending the app. | |||
| int mode = exclusive ? O_WRONLY | O_NONBLOCK : O_RDWR | O_NONBLOCK; | |||
|
|
|||
| auto report_err = [path = m_fifo_path](int err, const char* msg) { | |||
| auto message = util::format("%1: %2, path = '%3'", msg, std::system_category().message(err), path); | |||
| throw RuntimeError(ErrorCodes::FileOperationFailed, message); // LCOV_EXCL_LINE | |||
There was a problem hiding this comment.
i think we probably shouldn't worry about the cost of copying the string here, but should message be moved?
There was a problem hiding this comment.
I think not. RuntimeError takes a std::string_view as parameter.
jbreams
approved these changes
Aug 28, 2024
jbreams
approved these changes
Aug 28, 2024
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Fixes #7999 #8007
☑️ ToDos
bindgen/spec.yml, if public C++ API changed