Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix for realm-trawler #7989

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Small fix for realm-trawler #7989

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/realm/exec/realm_trawler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,16 +606,20 @@ void Table::print_columns(const Group& group) const
{
std::cout << " <" << m_table_type << ">\n";
for (unsigned i = 0; i < m_column_names.size(); i++) {
auto type = realm::ColumnType(m_column_types.get_val(i) & 0xFFFF);
auto type = m_column_types.get_val(i) & 0xFFFF;
auto attr = realm::ColumnAttr(m_column_attributes.get_val(i));
std::string type_str;
realm::ColKey col_key;
if (this->m_column_colkeys.valid()) {
// core6
col_key = realm::ColKey(m_column_colkeys.get_val(i));
}
if (type == 13) {
// type_LinkList == 13
type = 12;
}

if (type == realm::col_type_Link) {
if (type == 12) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: but isn't it easier to just if (type == 12 || type == 13)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then the call in line 635 would not work

size_t target_table_ndx;
if (col_key) {
// core6
Expand Down
Loading