Add option to replace binary separator with pipe #509
Conversation
|
@Nadia-Adaptive Have you considered adding |
| @@ -387,8 +405,8 @@ private static void print( | |||
| { | |||
| final MessageStatus status = message.status(); | |||
| final long timestamp = message.timestamp(); | |||
| final String body = message.body(); | |||
| System.out.printf("%1$20s: %2$s (%3$s)%n", timestamp, body, status); | |||
| final String body = pipeDelimiter ? message.body().replace('\u0001', '|') : message.body(); | |||
There was a problem hiding this comment.
I don't know how far you would like to take this, but SOH could also appear in data fields, so you might end up with pipe symbols in fields that should not be replaced.
But I think this approach is good enough for the majority of cases.
There was a problem hiding this comment.
Good point, thanks. I think this is good enough for now, fix.core.debug.separator doesn't handle data fields either.
We should implement this. |
| @@ -387,8 +405,8 @@ private static void print( | |||
| { | |||
| final MessageStatus status = message.status(); | |||
| final long timestamp = message.timestamp(); | |||
| final String body = message.body(); | |||
| System.out.printf("%1$20s: %2$s (%3$s)%n", timestamp, body, status); | |||
| final String body = pipeDelimiter ? message.body().replace('\u0001', '|') : message.body(); | |||
There was a problem hiding this comment.
Good point, thanks. I think this is good enough for now, fix.core.debug.separator doesn't handle data fields either.
|
|
||
|
|
||
|
|
||
|
|
...m-tests/src/test/java/uk/co/real_logic/artio/system_tests/ArchivePrinterIntegrationTest.java
Show resolved
Hide resolved
A change to FixArchivePrinter to allow replacing the binary separator in the FIX message body with a pipe via program arguments.