Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable MeshoptCompression #78

Merged
merged 13 commits into from
Jul 17, 2024
Merged

Enable MeshoptCompression #78

merged 13 commits into from
Jul 17, 2024

Conversation

ericjansenrpm
Copy link
Contributor

@ericjansenrpm ericjansenrpm requested a review from a team as a code owner July 9, 2024 13:15
@ericjansenrpm ericjansenrpm added the enhancement New feature or request label Jul 9, 2024
@ericjansenrpm ericjansenrpm self-assigned this Jul 9, 2024
yuri-wolf3d
yuri-wolf3d reviewed Jul 9, 2024
View reviewed changes
Copy link
Contributor

@yuri-wolf3d yuri-wolf3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avatar looks darker in the editor. It was the reason why we've locked the three.js version few months ago
image

@ericjansenrpm
Copy link
Contributor Author

Thanks for looking at it @yuri-wolf3d :) I only tested the light inside of storybook where this comparison was captured:

Screencast.from.2024-07-08.13-30-58.webm

I will revisit the settings and check that all cases are covered.

@ericjansenrpm ericjansenrpm marked this pull request as draft July 9, 2024 18:06
@ericjansenrpm ericjansenrpm marked this pull request as ready for review July 16, 2024 13:24
@ericjansenrpm
Copy link
Contributor Author

Ready for re-review. :) See this current comparison of old vs new:

image

image

yuri-wolf3d
yuri-wolf3d approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@yuri-wolf3d yuri-wolf3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for me it's still slightly different - not enough shadow on the left side (from our point of view), it's more noticieble on the face, and the hair looks a bit less voluminous. If it's possible to fix - nice, otherwise we can live with it. @blanxii wdyt?
image

src/services/Animation.service.ts Show resolved Hide resolved
src/components/Avatar/Avatar.component.tsx Show resolved Hide resolved
@ericjansenrpm ericjansenrpm merged commit 087e618 into main Jul 17, 2024
3 checks passed
@ericjansenrpm ericjansenrpm deleted the ACT-723-quantization branch July 17, 2024 15:05
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuri-wolf3d yuri-wolf3d yuri-wolf3d approved these changes

@blanxii blanxii Awaiting requested review from blanxii

Assignees

@ericjansenrpm ericjansenrpm

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericjansenrpm @blanxii @yuri-wolf3d