Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add color property to background prop #54

Merged
merged 2 commits into from
Sep 21, 2023
Merged

feat: add color property to background prop #54

merged 2 commits into from
Sep 21, 2023

Conversation

Zaehiel
Copy link
Contributor

@Zaehiel Zaehiel commented Sep 20, 2023 •
edited
Loading

Added

  • Allow explicitly setting background color to Avatar scene via background.color property.
    • ‼️ CSS should be avoided when trying to stylise the background as it causes visual defects when using emissive materials.

@Zaehiel Zaehiel self-assigned this Sep 20, 2023
@Zaehiel Zaehiel requested a review from tiivik as a code owner September 20, 2023 13:16
@Zaehiel Zaehiel marked this pull request as draft September 20, 2023 13:16
@Zaehiel Zaehiel marked this pull request as ready for review September 21, 2023 10:11
@Zaehiel Zaehiel merged commit 1e4e1a5 into main Sep 21, 2023
3 checks passed
@Zaehiel Zaehiel deleted the ACT-19-Background-color-gradients branch September 21, 2023 10:20
@github-actions
Copy link

🎉 This PR is included in version 4.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blanxii blanxii blanxii approved these changes

@chikul chikul Awaiting requested review from chikul

@tiivik tiivik Awaiting requested review from tiivik

Assignees

@Zaehiel Zaehiel

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zaehiel @blanxii