-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-697] Feature/remove permission override #26
Conversation
Editor/WebViewBuildPostprocessor.cs
Outdated
@@ -1,4 +1,4 @@ | |||
#if UNITY_EDITOR | |||
#if UNITY_EDITOR && RPM_WEBVIEW_PERMISIONS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo on the permissions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh damn nice catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overally looks good, but do we want this to be disabled by default? Or should we still add the macro to the unity, when project is imported? we don't know how many people don't need the permissions and how many do right?
It's a good question. Generally I would say that people would only need the permissions if targeting mobile AND they don't want to use the CAC.
The main problem I have with having permissions enabled by default is that it's forcing things that may not be need that can cause bugs, and could be overriding some of their own build post processors. However on the flipside if they do actually need the permissions for their app then of course being enabled by default would be useful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢
SDK-697
Description
RPM_WEBVIEW_PERMISIONS
With this update it will be disabled by default but they can re-enable by adding the above define symbol into player settings.
This will help developers when submitting to marketplaces that don't allow camera or other specific permissions.
Changes
Added
Updated
Removed
How to Test
Checklist