Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: log error, when bodyshapes are not enabled in studio #281

Merged
merged 3 commits into from
May 27, 2024
Merged

feat: log error, when bodyshapes are not enabled in studio #281

merged 3 commits into from
May 27, 2024

Conversation

rk132
Copy link
Contributor

@rk132 rk132 commented May 24, 2024 •
edited by jira bot
Loading

SDK-907

Description

  • Throw error, when body shapes are not enabled in the studio
image

How to Test

  • Enable body shapes in the studio and test, that shapes are applied and that no error is thrown
  • Disable body shapes in the studio and verify, that error is shown and avatar is not updated

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@rk132 rk132 requested a review from a team as a code owner May 24, 2024 12:58
HarrisonHough
HarrisonHough reviewed May 27, 2024
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions about implementation

Runtime/AvatarCreator/Scripts/Managers/AvatarManager.cs Outdated Show resolved Hide resolved
Runtime/AvatarCreator/Scripts/Managers/AvatarManager.cs Show resolved Hide resolved
@rk132 rk132 requested a review from HarrisonHough May 27, 2024 06:36
HarrisonHough
HarrisonHough approved these changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay how it is but I would still go with logging errors on builds also. It makes it easier to debug things if somebody misses the error when testing in editor.

@rk132 rk132 merged commit d1cd6ec into develop May 27, 2024
@rk132 rk132 deleted the feature/log-error-when-asset-was-not-applied branch May 27, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrisonHough HarrisonHough HarrisonHough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rk132 @HarrisonHough