Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-819] Feature/core settings fix #226

Merged
merged 4 commits into from
Feb 15, 2024
Merged

[SDK-819] Feature/core settings fix #226

merged 4 commits into from
Feb 15, 2024

Conversation

HarrisonHough
Copy link
Collaborator

@HarrisonHough HarrisonHough commented Feb 14, 2024 •
edited by jira bot
Loading

SDK-819

Description

  • this update fixes an issue causing core settings to be overwritten sometimes when the project is reopened.

How to Test

  • Add steps to locally test these changes

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@HarrisonHough HarrisonHough requested a review from a team as a code owner February 14, 2024 09:19
rk132
rk132 approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@rk132 rk132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@HarrisonHough HarrisonHough merged commit e351022 into develop Feb 15, 2024
5 of 6 checks passed
@HarrisonHough HarrisonHough deleted the feature/core-settings-fix branch February 15, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rk132 rk132 rk132 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HarrisonHough @rk132