Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update avatar creator simple scene to contain user management, create, and save avatar functionality #223

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

rk132
Copy link
Contributor

@rk132 rk132 commented Feb 12, 2024

SDK-683

image

Description

  • Update the avatar creator scene, so that you can log in/log out, and create and save new avatars from the template.

How to Test

  • Verify, that everything works

@rk132 rk132 requested a review from a team as a code owner February 12, 2024 07:30
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Not specifically related to this PR but I think there are some things we could add or improve on like:

  • On the Avatars (user avatars) panel it could show some text if it's empty like "Sign in to view avatars" or "no avatars found"
  • When you click "Select Avatar" on a user avatar in this example it actually does nothing. Perhaps we should make it load an avatar?
  • maybe a separate task to improve the UI layout a little. We don't need to focus too much making it pretty but maybe we can organize it in a way that makes it easier to understand. Like a panel with all the buttons and grouping under headings or something

@rk132
Copy link
Contributor Author

rk132 commented Feb 12, 2024

Looks good. Not specifically related to this PR but I think there are some things we could add or improve on like:

  • On the Avatars (user avatars) panel it could show some text if it's empty like "Sign in to view avatars" or "no avatars found"
  • When you click "Select Avatar" on a user avatar in this example it actually does nothing. Perhaps we should make it load an avatar?
  • maybe a separate task to improve the UI layout a little. We don't need to focus too much making it pretty but maybe we can organize it in a way that makes it easier to understand. Like a panel with all the buttons and grouping under headings or something

For the first point, I don't want to introduce any new scripts to the simple avatar creator. I want it to be as simple as possible. So if a developer wants a text there, then they can add it and react against the OnAvatarsLoaded event in the avatarListElement.

For the second point, makes sense. I didn't know as well what to do with that button to be fair 😅. I'll remove it from the list prefab for now as we don't manage "game state" right now. So there's no next state, where we can close the creator and show the avatar.

For the third point, will do 👍

@rk132 rk132 merged commit d66e4ce into develop Feb 12, 2024
@rk132 rk132 deleted the feature/update-experimental-avatar-creator-scene branch February 12, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants