Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-776] Feature/default asset selection #213

Merged
merged 5 commits into from
Feb 2, 2024
Merged

[SDK-776] Feature/default asset selection #213

merged 5 commits into from
Feb 2, 2024

Conversation

HarrisonHough
Copy link
Collaborator

@HarrisonHough HarrisonHough commented Feb 1, 2024 •
edited by jira bot
Loading

SDK-776

Description

  • Added default asset selection for template avatars

NOTE this only works for some assets, it doesn't work for outfits which is the same in web

How to Test

  • Run the Simple Avatar craetor (Avatar Creator Experimental) and check that after initial load the hair and eyebrows are selected already

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@HarrisonHough HarrisonHough requested a review from a team as a code owner February 1, 2024 08:19
rk132
rk132 approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@rk132 rk132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You still added the headwear and outfit to the onAvatarCreated list even tho they don't work right now. Should we remove it from the Scene list then?

@HarrisonHough HarrisonHough merged commit c65a498 into develop Feb 2, 2024
5 of 6 checks passed
@HarrisonHough HarrisonHough deleted the feature/default-asset-selection branch February 2, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rk132 rk132 rk132 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HarrisonHough @rk132