Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-658] Feature/asset store updates #195

Merged
merged 2 commits into from
Jan 2, 2024
Merged

[SDK-658] Feature/asset store updates #195

merged 2 commits into from
Jan 2, 2024

Conversation

HarrisonHough
Copy link
Collaborator

@HarrisonHough HarrisonHough commented Dec 22, 2023 •
edited by jira bot
Loading

SDK-658

Description

  • this PR includes a number of changes to make the SDK more compliant with the unity Asset store requirements
  • 1 script was edited so that it was wrapped in RPM namespace
  • removed the Ready Player Me custom file menu, now it is under Tools (as required by asset store)
  • fixed some issues related to paths like in the Graphics Setting Utility

How to Test

  • Add steps to locally test these changes

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@HarrisonHough HarrisonHough requested a review from a team as a code owner December 22, 2023 07:03
rk132
rk132 approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@rk132 rk132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but currently, the samples are not reachable via getting started guide. We prob need to fix that as well.

@HarrisonHough
Copy link
Collaborator Author

Looks good, but currently, the samples are not reachable via getting started guide. We prob need to fix that as well.

thanks for checking that. will make a separate task for this

@HarrisonHough HarrisonHough merged commit e2afffb into develop Jan 2, 2024
4 checks passed
@HarrisonHough HarrisonHough deleted the feature/asset-store-updates branch January 2, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rk132 rk132 rk132 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HarrisonHough @rk132