Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-593] Add permission and orientation fix to photo capture element #192

Merged
merged 1 commit into from
Jan 2, 2024
Merged

[SDK-593] Add permission and orientation fix to photo capture element #192

merged 1 commit into from
Jan 2, 2024

Conversation

rYuuk
Copy link
Contributor

@rYuuk rYuuk commented Dec 19, 2023 •
edited by jira bot
Loading

SDK-593

Description

  • Added fetching of camera permission for ios and android
  • Also fixed orientation of captured image

How to Test

  • Add steps to locally test these changes

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@rYuuk rYuuk self-assigned this Dec 19, 2023
HarrisonHough
HarrisonHough approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and seems to work, awesome stuff!

@rYuuk rYuuk force-pushed the feature/avatar-creator-mobile-cam branch from 80678cb to c59f5ed Compare January 2, 2024 10:03
@rYuuk rYuuk changed the title feat: add permission and orientation fix to photo capture element [SDK-593] Add permission and orientation fix to photo capture element Jan 2, 2024
@rYuuk rYuuk marked this pull request as ready for review January 2, 2024 10:06
@rYuuk rYuuk requested a review from a team as a code owner January 2, 2024 10:06
@rYuuk rYuuk merged commit bf39b05 into develop Jan 2, 2024
@rYuuk rYuuk deleted the feature/avatar-creator-mobile-cam branch January 2, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrisonHough HarrisonHough HarrisonHough approved these changes

Assignees

@rYuuk rYuuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rYuuk @HarrisonHough