Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-686] Feature/structure review #190

Merged
merged 12 commits into from
Dec 22, 2023
Merged

[SDK-686] Feature/structure review #190

merged 12 commits into from
Dec 22, 2023

Conversation

HarrisonHough
Copy link
Collaborator

@HarrisonHough HarrisonHough commented Dec 18, 2023 •
edited by jira bot
Loading

SDK-686

Description

  • A big core SDK folder/file reorg to match what standard packages use (at least for the root folders) separating into Runtime and Editor root folders
  • also move scripts into a Scripts folder

How to Test

  • Add steps to locally test these changes

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@HarrisonHough HarrisonHough requested a review from a team as a code owner December 18, 2023 11:12
rYuuk
rYuuk approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@rYuuk rYuuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Looks so clean now 🎉 💯
image

@HarrisonHough HarrisonHough merged commit 714e580 into develop Dec 22, 2023
@HarrisonHough HarrisonHough deleted the feature/structure-review branch December 22, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rYuuk rYuuk rYuuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HarrisonHough @rYuuk