Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-700] Add asset type filter #187

Merged
merged 3 commits into from
Dec 14, 2023
Merged

[SDK-700] Add asset type filter #187

merged 3 commits into from
Dec 14, 2023

Conversation

rYuuk
Copy link
Contributor

@rYuuk rYuuk commented Dec 13, 2023 •
edited by jira bot
Loading

SDK-700

Description

  • Added filter for asset type

How to Test

  • Check the SimpleAvatarCreator assetSelectionElements and observe the asset type enum showing correct types

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@rYuuk rYuuk self-assigned this Dec 13, 2023
@rYuuk rYuuk requested a review from a team as a code owner December 13, 2023 10:12
@rYuuk rYuuk changed the title feat: add asset type filter [SDK-700] Add asset type filter Dec 13, 2023
rk132
rk132 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@rk132 rk132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works nicely. 1 small comment.

Runtime/AvatarCreator/Data/AssetType.cs Outdated Show resolved Hide resolved
@rYuuk rYuuk merged commit 0e34dde into develop Dec 14, 2023
@rYuuk rYuuk deleted the feature/asset-type-filter branch December 14, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rk132 rk132 rk132 approved these changes

Assignees

@rYuuk rYuuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rYuuk @rk132