Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-695] Add avatar creator poc sample #182

Merged
merged 4 commits into from
Dec 6, 2023
Merged

[SDK-695] Add avatar creator poc sample #182

merged 4 commits into from
Dec 6, 2023

Conversation

rYuuk
Copy link
Contributor

@rYuuk rYuuk commented Dec 6, 2023 •
edited by jira bot
Loading

SDK-695

Description

  • Add avatar creator POC sample using new elements

How to Test

  • Run the sample

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@rYuuk rYuuk self-assigned this Dec 6, 2023
@rYuuk rYuuk requested a review from a team as a code owner December 6, 2023 07:01
HarrisonHough
HarrisonHough requested changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!
All looks good the 1 small thing that I think is just adjusting the sample structure a little.
Since this will be our 2nd cac example (albeit a POC) but we can set it up something like this (the subfolders I have here are terrible names so please feel free to improve there)
AvatarCreatorSamples
|- WizardStyleCreator
|- SimpleElementsCreator

@rYuuk
Copy link
Contributor Author

rYuuk commented Dec 6, 2023

This is awesome! All looks good the 1 small thing that I think is just adjusting the sample structure a little. Since this will be our 2nd cac example (albeit a POC) but we can set it up something like this (the subfolders I have here are terrible names so please feel free to improve there) AvatarCreatorSamples |- WizardStyleCreator |- SimpleElementsCreator

Changing the old sample folder structure will bloat this PR. I would suggest doing it in another ticket, what do you think?

@HarrisonHough
Copy link
Collaborator

This is awesome! All looks good the 1 small thing that I think is just adjusting the sample structure a little. Since this will be our 2nd cac example (albeit a POC) but we can set it up something like this (the subfolders I have here are terrible names so please feel free to improve there) AvatarCreatorSamples |- WizardStyleCreator |- SimpleElementsCreator

Changing the old sample folder structure will bloat this PR. I would suggest doing it in another ticket, what do you think?

Right valid point! lets do as separate task

@HarrisonHough HarrisonHough self-requested a review December 6, 2023 08:50
HarrisonHough
HarrisonHough approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG

@rYuuk rYuuk merged commit ce737b4 into develop Dec 6, 2023
@rYuuk rYuuk deleted the feature/avatar-creator-poc branch December 6, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrisonHough HarrisonHough HarrisonHough approved these changes

Assignees

@rYuuk rYuuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rYuuk @HarrisonHough