Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-685] Feature/avatar preview element #181

Merged
merged 5 commits into from
Dec 7, 2023

Conversation

HarrisonHough
Copy link
Collaborator

@HarrisonHough HarrisonHough commented Dec 5, 2023

SDK-685

Description

  • Adds an avatar preview prefab which combines the avatar rotation script and a new CameraFocuser script (open to better name suggestions for camera script).
  • I wasn't planning to change the way the Avatar rotation and input handling work but I think this new approach would be good as it enables devs to use other input sources (EG keyboard or controller) by using the IAvatarRotatorInput interface. But please give feedback on this

Component looks like this
image

Made a temp demo scene to make it easy to trigger the camera focus stuff if you check our the avatar-preview feature branch on Unity-SDK repo you can test for yourself
image

How to Test

  • if you check our the avatar-preview feature branch on Unity-SDK repo you can test for yourself in scene located in TEMP folder

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

@HarrisonHough HarrisonHough requested a review from a team as a code owner December 5, 2023 15:25
Copy link
Contributor

@rYuuk rYuuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tested, it looks good. A small comment.

@HarrisonHough HarrisonHough requested a review from rYuuk December 6, 2023 13:18
Copy link
Contributor

@rYuuk rYuuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Thanks for making the change.

@HarrisonHough HarrisonHough merged commit 98e99d6 into develop Dec 7, 2023
@HarrisonHough HarrisonHough deleted the feature/avatar-preview-element branch December 7, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants