[SDK-681] Add account creation element #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A minor thing but the prefabs buttons has a bunch of empty events assigned. |
HarrisonHough
approved these changes
Dec 5, 2023
| @@ -24,27 +23,24 @@ private void OnEnable() | |||
| { | |||
| sendEmailButton.onClick.AddListener(OnSendEmailButton); | |||
There was a problem hiding this comment.
In theory we could make this component slightly more flexible by removing the auto assigning of the event listeners and instead make the appropriate functions public and assign them in the inspector. It would also mean that you might need the button references. But not a blocker for me if you think it's unnecessary to do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK-681
Description
How to Test
Checklist