Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Uniform request naming #173

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Feature: Uniform request naming #173

merged 2 commits into from
Nov 30, 2023

Conversation

MaxAndreassenRPM
Copy link
Contributor

Base on our discussion yesterday, I've updated the naming of the base requests to be more uniform and reflective of the actual API resources.

image

@MaxAndreassenRPM MaxAndreassenRPM requested a review from a team as a code owner November 30, 2023 10:09
rYuuk
rYuuk approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@rYuuk rYuuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Thanks this makes api more consistent. Please also have a look at a small concern.

Runtime/AvatarCreator/WebRequests/AuthorizedRequest.cs Outdated Show resolved Hide resolved
rk132
rk132 reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@rk132 rk132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having the API in the name makes it so much clearer 😄

@MaxAndreassenRPM MaxAndreassenRPM merged commit 2fea523 into develop Nov 30, 2023
@MaxAndreassenRPM MaxAndreassenRPM deleted the feature/uniform-request-naming branch November 30, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rk132 rk132 rk132 left review comments

@rYuuk rYuuk rYuuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxAndreassenRPM @rYuuk @rk132